Hi Peter, On 1 July 2019 3:44:08 AM IST, Peter Robinson <pbrobinson@xxxxxxxxx> wrote: >BCM4356 devices soldered onto the PCB (non-removable) use an UART >connection for bluetooth, such as the Rock960, but it also advertise >btsdio support as a sdio function. Sorry, I don't get the point of this patch. What if BCM4356 is used in different configuration on some other platform (using SDIO for Bluetooth but still soldered on the PCB)? I haven't seen any such but just curious what if! Thanks, Mani > >Signed-off-by: Peter Robinson <pbrobinson@xxxxxxxxx> >CC: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> >--- > drivers/bluetooth/btsdio.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c >index 83748b7b2033..fd9571d5fdac 100644 >--- a/drivers/bluetooth/btsdio.c >+++ b/drivers/bluetooth/btsdio.c >@@ -286,6 +286,7 @@ static int btsdio_probe(struct sdio_func *func, > switch (func->device) { > case SDIO_DEVICE_ID_BROADCOM_43341: > case SDIO_DEVICE_ID_BROADCOM_43430: >+ case SDIO_DEVICE_ID_BROADCOM_4356: > return -ENODEV; > } > } -- Sent from my Android device with K-9 Mail. Please excuse my brevity.