Greg, Can we get this revert merged into stable branches? Bluetooth HID has been broken for many devices for quite a while now and RFC patch that fixes the breakage hasn't seen any movement for almost a month. Regards, Vasily On Thu, May 23, 2019 at 7:52 AM Vasily Khoruzhick <anarsoul@xxxxxxxxx> wrote: > > On Wed, May 22, 2019 at 12:08 AM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > > > > Hi Vasily, > > > > >> This reverts commit d5bb334a8e171b262e48f378bd2096c0ea458265. > > >> > > >> This commit breaks some HID devices, see [1] for details > > >> > > >> https://bugzilla.kernel.org/show_bug.cgi?id=203643 > > >> > > >> Signed-off-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx> > > >> Cc: stable@xxxxxxxxxxxxxxx > > > > > > let me have a look at this. Maybe there is a missing initialization for older HID devices that we need to handle. Do you happen to have the full btmon binary trace from controller initialization to connection attempt for me? > > > > > > Are both devices Bluetooth 2.1 or later device that are supporting Secure Simple Pairing? Or is one of them a Bluetooth 2.0 or earlier device? > > > > I am almost certain that you have a Bluetooth 2.0 mouse. I made a really stupid mistake in the key size check logic and forgot to bind it to SSP support. Can you please check the patch that I just send you. > > > > https://lore.kernel.org/linux-bluetooth/20190522070540.48895-1-marcel@xxxxxxxxxxxx/T/#u > > This patch fixes the issue for me. Thanks! > > > > > Regards > > > > Marcel > >
