Hi Inga,
On 06/05, Stotland, Inga wrote:
> On Wed, 2019-06-05 at 15:01 +0200, Jakub Witowski wrote:
> > Netwrk keys, application keys and elements with models have been
> > simplified in json storage file. Arrays objects are no longer
> > required.
> The proposed change would be okay if not for the fact that we plan to
> re-use the same code for storing the information database for
> provisioner/configuration client. That puts constraints on the format
> in which the json data is stored.
Could you please elaborate?
The patchset doesn't change much in terms of JSON format, it just
replaces thing like:
"netKeys": [
{ "index": "0000", <params...> },
{ "index": "0001", <params...> }
],
"elements": [
{ "elementIndex": 0, <params...> }
]
with:
"netKeys": {
"0000": { <params> },
"0001": { <params> }
},
"elements": {
"0": { <params...> }
}
The latter format should allow storing exactly the same information, but in a
slightly more straightforward manner.
> (...) use customized routines to implement them.
> That should allow you to keep local node configuration in your own
> format.
We would very much like to avoid vendor patches. From our POV the whole
point of open source collaboration is to make the *mainline* usable for
as many people as possible.
regards
--
Michał Lowas-Rzechonek <michal.lowas-rzechonek@xxxxxxxxxxx>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND
