On Dienstag, 19. Februar 2019 15:14:01 CEST Rob Herring wrote: > > > How is this used? > > > > rtl8723bs-bt needs 2 firmware binaries -- one is actual firmware, > > another is firmware config which is specific to the board. If > > firmware-postfix is specified, driver appends it to the name of config > > and requests board-specific config while loading firmware. I.e. if > > 'pine64' is specified as firmware-postfix driver will load > > rtl8723bs_config-pine64.bin. > > We already have 'firmware-name' defined and I'd prefer not to have > another way to do things. The difference is just you have to give the > full filename. > Hi Rob, I'm working on a v2 for this patchset and I've looked on how using "firmware- name" with the full filename would be possible but as David Summers has already written [1], the existing code [2] takes this "postfix" as parameter and basically fills it into a filename template ("${CFG_NAME}-${POSTFIX}.bin"). So either we stay with the "firmware-postfix" property or the existing code would have to be modified to accomodate the full filename; but if using firmware-postfix is unacceptable, I can rework the existing code. Luca [1] https://lore.kernel.org/netdev/d06e3c30-a34a-bd84-9cdf-535f253843e3@xxxxxxxxxxxxxxxxxxx/ [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/ drivers/bluetooth/btrtl.c#n566
Attachment:
signature.asc
Description: This is a digitally signed message part.