System may freeze during suspend, and it's caused by btusb early wakeup: kernel: pci_pm_suspend(): hcd_pci_suspend+0x0/0x30 returns -16 kernel: dpm_run_callback(): pci_pm_suspend+0x0/0x130 returns -16 kernel: PM: Device 0000:00:14.0 failed to suspend async: error -16 kernel: PM: Some devices failed to suspend, or early wake event detected kernel: usb usb1: usb resume kernel: hub 1-0:1.0: hub_resume kernel: usb usb1-port1: status 0507 change 0000 kernel: usb usb1-port6: status 0103 change 0004 kernel: usb usb1-port10: status 0107 change 0000 where btusb is connecte to usb1-port6. The expirement shows that the early wakeup is caused by LE Advertising packet. Disabling it via event mask can prevent the issue from happening. BugLink: https://bugs.launchpad.net/bugs/1823029 Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> --- v2: - Abstract away enabling/disabling LE advertising from btusb. drivers/bluetooth/btusb.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 7db48ae65cd2..c3ae066910f2 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -494,6 +494,7 @@ struct btusb_data { int oob_wake_irq; /* irq for out-of-band wake-on-bt */ unsigned cmd_timeout_cnt; + bool suspended; }; @@ -3351,12 +3352,18 @@ static void btusb_disconnect(struct usb_interface *intf) static int btusb_suspend(struct usb_interface *intf, pm_message_t message) { struct btusb_data *data = usb_get_intfdata(intf); + struct hci_dev *hdev = data->hdev; BT_DBG("intf %p", intf); if (data->suspend_count++) return 0; + if (!PMSG_IS_AUTO(message)) { + hci_suspend_dev(hdev); + data->suspended = true; + } + spin_lock_irq(&data->txlock); if (!(PMSG_IS_AUTO(message) && data->tx_in_flight)) { set_bit(BTUSB_SUSPENDING, &data->flags); @@ -3462,6 +3469,11 @@ static int btusb_resume(struct usb_interface *intf) spin_unlock_irq(&data->txlock); schedule_work(&data->work); + if (data->suspended) { + hci_resume_dev(hdev); + data->suspended = false; + } + return 0; failed: -- 2.17.1
