> On 23 Apr 2019, at 19:01, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > > Hi Bastien, > >>>> --- >>>> Makefile.tools | 5 ++++- >>>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Makefile.tools b/Makefile.tools >>>> index 7d5361bcd..9f8a0b87b 100644 >>>> --- a/Makefile.tools >>>> +++ b/Makefile.tools >>>> @@ -436,7 +436,10 @@ endif >>>> endif >>>> >>>> if CUPS >>>> -cupsdir = $(libdir)/cups/backend >>>> +# need to use upstream location here which is >>>> $exec_prefix/lib/cups/backend, see >>>> +# >>>> https://github.com/apple/cups/blob/master/config-scripts/cups-directories.m4 >>>> +# https://github.com/apple/cups/blob/master/backend/Makefile >>>> +cupsdir = $(exec_prefix)/lib/cups/backend >>>> >>>> cups_PROGRAMS = profiles/cups/bluetooth >>> >>> Any feedback on these changes? >> >> The Fedora package has been doing that manually for 11 years, so, yes >> that looks correct. >> >> It should probably be using the output of >> "cups-config --serverbin" instead, but given how hard that is with >> autotools, this is probably fine. I'd mention it in the commend instead >> of linking at the code though. > > can someone add pkg-config support to CUPS. Then we can just get the directory from there. We are doing it this way for D-Bus and systemd. IIRC, Apple, the maintainer of CUPS, has refused pkg-config support in the past. So best not wait for that. > > Regards > > Marcel > >
