Re: [Patch net v2 2/3] bluetooth: validate HCI_EV_LE_META packet carefully

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [Patch net v2 2/3] bluetooth: validate HCI_EV_LE_META packet carefully
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Fri, 5 Apr 2019 23:09:29 +0300
Cc: Linux Kernel Network Developers <netdev@xxxxxxxxxxxxxxx>, linux-bluetooth <linux-bluetooth@xxxxxxxxxxxxxxx>, Marcel Holtmann <marcel@xxxxxxxxxxxx>, Johan Hedberg <johan.hedberg@xxxxxxxxx>, Tomas Bortoli <tomasbortoli@xxxxxxxxx>
In-reply-to: <CAM_iQpXnPyqGxgPF19CA9n=DGYmJ9d-Vn4fvu1kKunonPKpW6A@mail.gmail.com>
References: <20190403230835.1174-1-xiyou.wangcong@gmail.com> <20190403230835.1174-3-xiyou.wangcong@gmail.com> <20190404083449.GL32613@kadam> <CAM_iQpXnPyqGxgPF19CA9n=DGYmJ9d-Vn4fvu1kKunonPKpW6A@mail.gmail.com>
User-agent: Mutt/1.9.4 (2018-02-28)

As I explained in my email, the original code is buggy if
num_reports > 1 (probably uncommon), but your code is buggy for
num_reports >= 1 (everything).

regards,
dan carpenter

References:
- [Patch net v2 0/3] bluetooth: validate packet boundary carefully
  - From: Cong Wang
- [Patch net v2 2/3] bluetooth: validate HCI_EV_LE_META packet carefully
  - From: Cong Wang
- Re: [Patch net v2 2/3] bluetooth: validate HCI_EV_LE_META packet carefully
  - From: Dan Carpenter
- Re: [Patch net v2 2/3] bluetooth: validate HCI_EV_LE_META packet carefully
  - From: Cong Wang

Prev by Date: Re: [PATCH BlueZ 1/1] mesh: Add APIs for Provisioner and Config Client
Next by Date: Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events
Previous by thread: Re: [Patch net v2 2/3] bluetooth: validate HCI_EV_LE_META packet carefully
Next by thread: [Patch net v2 3/3] bluetooth: validate HCI_EV_CMD_COMPLETE packet carefully
Index(es):
- Date
- Thread

[Index of Archives] [Bluez Devel] [Linux Wireless Networking] [Linux Wireless Personal Area Networking] [Linux ATH6KL] [Linux USB Devel] [Linux Media Drivers] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Big List of Linux Books]