On Tue, Apr 02, 2019 at 10:42:38AM -0700, Cong Wang wrote: > > Btw, get rid of all the likely/unlikely() macros. Then the other style > > comment would be don't move the "ev = (void *)skb->data;" assignments > > around. It's ok to say: > > > Similarly, pskb_may_pull() may reallocate skb's, although very unlikely > for bluetooth case (skb's are linear). At least it doesn't harm anything > we move the skb->data dereference after pskb_may_pull(). > It harms readability. regards, dan carpenter
