Hi SpoorthiX, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bluetooth-next/master] [also build test WARNING on v5.1-rc2 next-20190327] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/SpoorthiX-K/Add-Support-for-LE-Ping-feature/20190327-182038 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' sparse warnings: (new ones prefixed by >>) >> net/bluetooth/hci_event.c:3010:28: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [unsigned] [assigned] [usertype] timeout @@ got igned] [assigned] [usertype] timeout @@ net/bluetooth/hci_event.c:3010:28: expected unsigned short [unsigned] [assigned] [usertype] timeout net/bluetooth/hci_event.c:3010:28: got restricted __le16 [usertype] <noident> include/linux/overflow.h:285:13: sparse: undefined identifier '__builtin_mul_overflow' include/linux/overflow.h:285:13: sparse: incorrect type in conditional include/linux/overflow.h:285:13: got void include/linux/overflow.h:287:13: sparse: undefined identifier '__builtin_add_overflow' include/linux/overflow.h:287:13: sparse: incorrect type in conditional include/linux/overflow.h:287:13: got void include/linux/overflow.h:285:13: sparse: not a function <noident> include/linux/overflow.h:285:13: sparse: incorrect type in conditional include/linux/overflow.h:285:13: got void include/linux/overflow.h:287:13: sparse: not a function <noident> include/linux/overflow.h:287:13: sparse: incorrect type in conditional include/linux/overflow.h:287:13: got void include/linux/overflow.h:285:13: sparse: call with no type! include/linux/overflow.h:287:13: sparse: call with no type! vim +3010 net/bluetooth/hci_event.c 2904 2905 static void hci_encrypt_change_evt(struct hci_dev *hdev, struct sk_buff *skb) 2906 { 2907 struct hci_ev_encrypt_change *ev = (void *) skb->data; 2908 struct hci_conn *conn; 2909 2910 BT_DBG("%s status 0x%2.2x", hdev->name, ev->status); 2911 2912 hci_dev_lock(hdev); 2913 2914 conn = hci_conn_hash_lookup_handle(hdev, __le16_to_cpu(ev->handle)); 2915 if (!conn) 2916 goto unlock; 2917 2918 if (!ev->status) { 2919 if (ev->encrypt) { 2920 /* Encryption implies authentication */ 2921 set_bit(HCI_CONN_AUTH, &conn->flags); 2922 set_bit(HCI_CONN_ENCRYPT, &conn->flags); 2923 conn->sec_level = conn->pending_sec_level; 2924 2925 /* P-256 authentication key implies FIPS */ 2926 if (conn->key_type == HCI_LK_AUTH_COMBINATION_P256) 2927 set_bit(HCI_CONN_FIPS, &conn->flags); 2928 2929 if ((conn->type == ACL_LINK && ev->encrypt == 0x02) || 2930 conn->type == LE_LINK) 2931 set_bit(HCI_CONN_AES_CCM, &conn->flags); 2932 } else { 2933 clear_bit(HCI_CONN_ENCRYPT, &conn->flags); 2934 clear_bit(HCI_CONN_AES_CCM, &conn->flags); 2935 } 2936 } 2937 2938 /* We should disregard the current RPA and generate a new one 2939 * whenever the encryption procedure fails. 2940 */ 2941 if (ev->status && conn->type == LE_LINK) { 2942 hci_dev_set_flag(hdev, HCI_RPA_EXPIRED); 2943 hci_adv_instances_set_rpa_expired(hdev, true); 2944 } 2945 2946 clear_bit(HCI_CONN_ENCRYPT_PEND, &conn->flags); 2947 2948 if (ev->status && conn->state == BT_CONNECTED) { 2949 if (ev->status == HCI_ERROR_PIN_OR_KEY_MISSING) 2950 set_bit(HCI_CONN_AUTH_FAILURE, &conn->flags); 2951 2952 hci_disconnect(conn, HCI_ERROR_AUTH_FAILURE); 2953 hci_conn_drop(conn); 2954 goto unlock; 2955 } 2956 2957 /* In Secure Connections Only mode, do not allow any connections 2958 * that are not encrypted with AES-CCM using a P-256 authenticated 2959 * combination key. 2960 */ 2961 if (hci_dev_test_flag(hdev, HCI_SC_ONLY) && 2962 (!test_bit(HCI_CONN_AES_CCM, &conn->flags) || 2963 conn->key_type != HCI_LK_AUTH_COMBINATION_P256)) { 2964 hci_connect_cfm(conn, HCI_ERROR_AUTH_FAILURE); 2965 hci_conn_drop(conn); 2966 goto unlock; 2967 } 2968 2969 /* Try reading the encryption key size for encrypted ACL links */ 2970 if (!ev->status && ev->encrypt && conn->type == ACL_LINK) { 2971 struct hci_cp_read_enc_key_size cp; 2972 struct hci_request req; 2973 2974 /* Only send HCI_Read_Encryption_Key_Size if the 2975 * controller really supports it. If it doesn't, assume 2976 * the default size (16). 2977 */ 2978 if (!(hdev->commands[20] & 0x10)) { 2979 conn->enc_key_size = HCI_LINK_KEY_SIZE; 2980 goto notify; 2981 } 2982 2983 hci_req_init(&req, hdev); 2984 2985 cp.handle = cpu_to_le16(conn->handle); 2986 hci_req_add(&req, HCI_OP_READ_ENC_KEY_SIZE, sizeof(cp), &cp); 2987 2988 if (hci_req_run_skb(&req, read_enc_key_size_complete)) { 2989 bt_dev_err(hdev, "sending read key size failed"); 2990 conn->enc_key_size = HCI_LINK_KEY_SIZE; 2991 goto notify; 2992 } 2993 2994 goto unlock; 2995 } 2996 /* Set the default Authenticated Payload Timeout after 2997 * an LE Link is established. As per Core Spec v5.0, Vol 2, Part B 2998 * Section 3.3, the HCI command WRITE_AUTH_PAYLOAD_TIMEOUT should be 2999 * sent when the link is active and Encryption is enabled, the conn 3000 * type can be either LE or ACL and controller must support LMP Ping. 3001 * Ensure for AES-CCM encryption as well. 3002 */ 3003 if ((conn->type == LE_LINK || conn->type == ACL_LINK) & 3004 lmp_ping_capable(hdev) && 3005 test_bit(HCI_CONN_ENCRYPT, &conn->flags) && 3006 test_bit(HCI_CONN_AES_CCM, &conn->flags)) { 3007 struct hci_cp_write_auth_payload_to cp; 3008 3009 cp.handle = cpu_to_le16(conn->handle); > 3010 cp.timeout = cpu_to_le16(hdev->auth_payload_timeout); 3011 hci_send_cmd(conn->hdev, HCI_OP_WRITE_AUTH_PAYLOAD_TO, 3012 sizeof(cp), &cp); 3013 } else { 3014 conn->state = BT_CONNECTED; 3015 hci_connect_cfm(conn, ev->status); 3016 } 3017 3018 notify: 3019 if (conn->state == BT_CONFIG) { 3020 if (!ev->status) 3021 conn->state = BT_CONNECTED; 3022 3023 hci_connect_cfm(conn, ev->status); 3024 hci_conn_drop(conn); 3025 } else 3026 hci_encrypt_cfm(conn, ev->status, ev->encrypt); 3027 3028 unlock: 3029 hci_dev_unlock(hdev); 3030 } 3031 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
