Re: [PATCH BlueZ] test: Enable test-mesh to send raw vendor commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

> On Mar 22, 2019, at 12:02 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> 
> Hi Inga,
> 
>> On 22 Mar 2019, at 5.49, Inga Stotland <inga.stotland@xxxxxxxxx> wrote:
>> +#       5 - on/off model client menu
>> +#       6 - send raw message
>> +#       7 - exit
> 
> Please don’t use numeric identifiers for commands in interactive tools. Use intuitive, human readable strings like we do in the other interactive tools in the tree. Numbers might be convenient for computers, but they’re not particularly human friendly :)

We do plan on making better tools, but this is mostly intended as a tester script to quickly allow us to test stuff, particularly the d-bus APIs, and demonstrate the way the methods are called from python.


> 
> Johan



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux