Hi,
On Mon, Mar 18, 2019 at 6:19 PM Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
>
> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>
> This logs errors with included service so it is easier to noticed when
> they are malformed.
> ---
> src/shared/gatt-client.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/src/shared/gatt-client.c b/src/shared/gatt-client.c
> index 1119d1a34..ec1041f66 100644
> --- a/src/shared/gatt-client.c
> +++ b/src/shared/gatt-client.c
> @@ -532,12 +532,19 @@ static void discover_incl_cb(bool success, uint8_t att_ecode,
> "uuid: %s", handle, start, end, uuid_str);
>
> attr = gatt_db_get_attribute(client->db, start);
> - if (!attr)
> + if (!attr) {
> + util_debug(client->debug_callback, client->debug_data,
> + "Unable to find attribute at 0x%04x", start);
> goto failed;
> + }
>
> attr = gatt_db_insert_included(client->db, handle, attr);
> - if (!attr)
> + if (!attr) {
> + util_debug(client->debug_callback, client->debug_data,
> + "Unable to add include attribute at 0x%04x",
> + handle);
> goto failed;
> + }
>
> /*
> * GATT requires that all include definitions precede
> @@ -545,8 +552,12 @@ static void discover_incl_cb(bool success, uint8_t att_ecode,
> * these entries, the correct handle must be assigned to the new
> * attribute.
> */
> - if (gatt_db_attribute_get_handle(attr) != handle)
> + if (gatt_db_attribute_get_handle(attr) != handle) {
> + util_debug(client->debug_callback, client->debug_data,
> + "Invalid attribute 0x%04x expect it at 0x%04x",
> + gatt_db_attribute_get_handle(attr), handle);
> goto failed;
> + }
> }
>
> next:
> --
> 2.20.1
>
Applied.
--
Luiz Augusto von Dentz
