Re: [PATCH v2 1/8] doc/media-api: Enable MediaEndpoint to expose remote SEP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pali,

On Mon, Jan 21, 2019 at 8:30 PM Pali Rohár <pali.rohar@xxxxxxxxx> wrote:
>
> On Monday 21 January 2019 20:25:41 Luiz Augusto von Dentz wrote:
> > Hi,
> > On Tue, Jan 15, 2019 at 4:12 PM Luiz Augusto von Dentz
> > <luiz.dentz@xxxxxxxxx> wrote:
> > >
> > > From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
> > >
> > > This adds the possibility to expose remote SEP using MediaEndpoint
> > > interface to allow setting a configuration.
> > > ---
> > >  doc/media-api.txt | 27 +++++++++++++++++++++++++--
> > >  1 file changed, 25 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/doc/media-api.txt b/doc/media-api.txt
> > > index b5ad2db12..af9485342 100644
> > > --- a/doc/media-api.txt
> > > +++ b/doc/media-api.txt
> > > @@ -500,14 +500,23 @@ Properties        object Player [readonly]
> > >  MediaEndpoint1 hierarchy
> > >  ========================
> > >
> > > -Service                unique name
> > > +Service                unique name (Server role)
> > > +               org.bluez (Client role)
> > >  Interface      org.bluez.MediaEndpoint1
> > > -Object path    freely definable
> > > +Object path    freely definable (Server role)
> > > +               [variable prefix]/{hci0,hci1,...}/dev_XX_XX_XX_XX_XX_XX/sepX
> > > +               (Client role)
> > >
> > >  Methods                void SetConfiguration(object transport, dict properties)
> > >
> > >                         Set configuration for the transport.
> > >
> > > +                       For client role transport must be set with a server
> > > +                       endpoint oject which will be configured and the
> > > +                       properties must contain the following properties:
> > > +
> > > +                               array{byte} Capabilities
> > > +
> > >                 array{byte} SelectConfiguration(array{byte} capabilities)
> > >
> > >                         Select preferable configuration from the supported
> > > @@ -532,6 +541,20 @@ Methods            void SetConfiguration(object transport, dict properties)
> > >                         endpoint, because when this method gets called it has
> > >                         already been unregistered.
> > >
> > > +Properties     string UUID [readonly, optional]:
> > > +
> > > +                       UUID of the profile which the endpoint is for.
> > > +
> > > +               byte Codec [readonly, optional]:
> > > +
> > > +                       Assigned number of codec that the endpoint implements.
> > > +                       The values should match the profile specification which
> > > +                       is indicated by the UUID.
> > > +
> > > +               array{byte} Capabilities [readonly, optional]:
> > > +
> > > +                       Capabilities blob, it is used as it is so the size and
> > > +                       byte order must match.
> > >
> > >  MediaTransport1 hierarchy
> > >  =========================
> > > --
> > > 2.17.2
> >
> > Are there any comments for this set? Notice that I did include the
> > device path in this set so there is no need to hack to guess what
> > device the endpoint belongs to.
>
> I did not know about V2 as I'm not subscribed to list. I tested and used
> with PA only V1.

I will send a v3 which does the reverse discovery, that should make it
work with existing paired devices that reconnect and configure since
otherwise there would not be any endpoints to associate with. Note
though that in case of PA the endpoint object should be considered
optional no matter what since otherwise it won't be backward
compatible.

-- 
Luiz Augusto von Dentz




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux