Hi Marcel, > -----Original Message----- > From: Marcel Holtmann [mailto:marcel@xxxxxxxxxxxx] > Sent: Monday, December 24, 2018 1:10 PM > To: Gix, Brian <brian.gix@xxxxxxxxx> > Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Johan Hedberg > <johan.hedberg@xxxxxxxxx>; Stotland, Inga <inga.stotland@xxxxxxxxx> > Subject: Re: [PATCH BlueZ v5 27/30] mesh: Sample Provisioning Agent > > Hi Brian, > > > --- > > mesh/agent.py | 40 ++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > create mode 100755 mesh/agent.py > > no, these all belong in the test directory. And we never used the .py suffix > either. The python scripts are all being moved to the test directory, but one point of clarification here: agent.py is not stand-alone. It is imported into other files, much like the existing files: ./test/bluezutils.py ./test/dbusdef.py ./test/sap_client.py This is the standard naming convention for included/imported python modules, and while it *is* possible to include modules that do not follow that naming convention, it is ugly, and will not seem "Natural" to anyone from the python world coming in and trying to use these modules in BlueZ. It would be like not using the ".h" extension on C header files. Are you absolutely *certain* that you want to break with python precedence in order to avoid using the .py file name extension? > > Regards > > Marcel
