On Wed, Nov 7, 2018 at 5:10 PM Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
>
> Hi Jaganath,
> On Tue, Nov 6, 2018 at 11:38 AM Jaganath K <jaganath.k.os@xxxxxxxxx> wrote:
> >
> > Hi,
> > On Thu, Oct 25, 2018 at 2:06 PM Jaganath Kanakkassery
> > <jaganath.k.os@xxxxxxxxx> wrote:
> > >
> > > This also adds LE prefix for LE phys to make it more
> > > descriptive
> > > ---
> > > lib/mgmt.h | 32 ++++++++++++++++---------
> > > tools/btmgmt.c | 75 ++++++++++++++++++++++++++++++++++------------------------
> > > 2 files changed, 65 insertions(+), 42 deletions(-)
> > >
> > > diff --git a/lib/mgmt.h b/lib/mgmt.h
> > > index ec6a380..570dec9 100644
> > > --- a/lib/mgmt.h
> > > +++ b/lib/mgmt.h
> > > @@ -552,16 +552,26 @@ struct mgmt_cp_set_appearance {
> > >
> > > #define MGMT_OP_GET_PHY_CONFIGURATION 0x0044
> > > struct mgmt_rp_get_phy_confguration {
> > > - uint16_t supported_phys;
> > > - uint16_t selected_phys;
> > > -} __packed;
> > > -
> > > -#define MGMT_PHY_LE_1M_TX 0x0001
> > > -#define MGMT_PHY_LE_1M_RX 0x0002
> > > -#define MGMT_PHY_LE_2M_TX 0x0004
> > > -#define MGMT_PHY_LE_2M_RX 0x0008
> > > -#define MGMT_PHY_LE_CODED_TX 0x0010
> > > -#define MGMT_PHY_LE_CODED_RX 0x0020
> > > + uint32_t supported_phys;
> > > + uint32_t configurable_phys;
> > > + uint32_t selected_phys;
> > > +} __packed;
>
> Is this a change in the protocol? It looks like the phys are now 32
> bits, or is this an actual fix and that the way the kernel communicate
> then? Either way this should probably be split from the changes to the
> PHY strings.
>
Actually we added BREDR packet types also to PHYs and along with that
made phy types 32 bit.
So this change is mainly for that. One more change is renaming of LE
PHY strings which i have
mentioned in the commit description. You want that to be in a separate patch?
Thanks,
Jaganath
