Hi Mallikarjun,
> Changes added to rename the l2cap connect/create result values.
> Result values specific to LE Credit based connection are renamed
> as L2CAP_CR_LE*, and changed the old names wherever they were used.
>
> Signed-off-by: Mallikarjun Phulari <mallikarjun.phulari@xxxxxxxxx>
> ---
> include/net/bluetooth/l2cap.h | 29 +++++++++++++++++------------
> net/bluetooth/l2cap_core.c | 12 ++++++------
> 2 files changed, 23 insertions(+), 18 deletions(-)
>
> diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> index 0697fd4..35788d9 100644
> --- a/include/net/bluetooth/l2cap.h
> +++ b/include/net/bluetooth/l2cap.h
> @@ -270,19 +270,24 @@ struct l2cap_conn_rsp {
> #define L2CAP_CID_DYN_END 0xffff
> #define L2CAP_CID_LE_DYN_END 0x007f
>
> +/* Renaming the result values specific to
> + * LE Credit based connection as L2CAP_CR_LE_*,
> + * And changing the old result value wherever they were used
> + */
why is this a comment?
> +
> /* connect/create channel results */
> -#define L2CAP_CR_SUCCESS 0x0000
> -#define L2CAP_CR_PEND 0x0001
> -#define L2CAP_CR_BAD_PSM 0x0002
> -#define L2CAP_CR_SEC_BLOCK 0x0003
> -#define L2CAP_CR_NO_MEM 0x0004
> -#define L2CAP_CR_BAD_AMP 0x0005
> -#define L2CAP_CR_AUTHENTICATION 0x0005
> -#define L2CAP_CR_AUTHORIZATION 0x0006
> -#define L2CAP_CR_BAD_KEY_SIZE 0x0007
> -#define L2CAP_CR_ENCRYPTION 0x0008
> -#define L2CAP_CR_INVALID_SCID 0x0009
> -#define L2CAP_CR_SCID_IN_USE 0x000A
> +#define L2CAP_CR_SUCCESS 0x0000
> +#define L2CAP_CR_PEND 0x0001
> +#define L2CAP_CR_BAD_PSM 0x0002
> +#define L2CAP_CR_SEC_BLOCK 0x0003
> +#define L2CAP_CR_NO_MEM 0x0004
> +#define L2CAP_CR_BAD_AMP 0x0005
Keep the original BR/EDR in a separate block. So an empty line here and no need to realign them.
Then create this a block and add comment /* credit based connect results */
And it needs the following:
L2CAP_CR_LE_SUCCESS 0x0000
L2CAP_CR_LE_BAD_PSM 0x0001
L2CAP_CR_LE_NO_MEM 0x0004
And they need to be used for the LE side instead of the BR/EDR ones.
> +#define L2CAP_CR_LE_AUTHENTICATION 0x0005
> +#define L2CAP_CR_LE_AUTHORIZATION 0x0006
> +#define L2CAP_CR_LE_BAD_KEY_SIZE 0x0007
> +#define L2CAP_CR_LE_ENCRYPTION 0x0008
> +#define L2CAP_CR_LE_INVALID_SCID 0x0009
> +#define L2CAP_CR_LE_SCID_IN_USE 0x000A
Regards
Marcel
