On Thu, Sep 20, 2018 at 06:45:58PM -0400, Sinan Kaya wrote: > On 9/20/2018 6:34 PM, Matthias Kaehlcke wrote: > > On some systems the Bluetooth Device Address (BD_ADDR) isn't stored > > on the Bluetooth chip itself. One way to configure the BD address is > > through the device tree. The btqcomsmd driver is an example, it can > > read the BD address from the DT property 'local-bd-address'. It is > > also planned to extend the hci_qca driver to support setting the BD > > address through the DT. > > > > To avoid redundant open-coded reading of 'local-bd-address' and error > > handling this series adds an API to retrieve the BD address of a device > > and adapts the btqcomsmd driver to use this API. > > I don't think you have got enough number of line savings to make this > code to be folded into property.c Most of the new lines are documentation ;-) > Not my call but seems redundant IMO. Certainly true if this was the only driver. However another one will follow soon and 'local-bd-address' is the official binding, so it's not unlikely there will be more. Also fwnode_get_bd_address() handles the case where the property exists but is all zeros which adds a few LOC, which isn't handled by the btqcomsmd driver. Cheers Matthias
