Hi,
On Fri, Aug 24, 2018 at 9:02 AM, Yu, Mingli <mingli.yu@xxxxxxxxxxxxx> wrote:
> Correct the commit author.
>
> Thanks,
>
>
> On 2018年08月24日 13:28, Yu, Mingli wrote:
>>
>> Please ignore this.
>>
>> Thanks,
>>
>>
>> On 2018年08月24日 13:30, mingli.yu@xxxxxxxxxxxxx wrote:
>>>
>>> From: Brian Gix <brian.gix@xxxxxxxxx>
>>>
>>> The below test hangs infinitely
>>> $ unit/test-gatt -p /robustness/unkown-request -d
>>> /robustness/unkown-request - init
>>> /robustness/unkown-request - setup
>>> /robustness/unkown-request - setup complete
>>> /robustness/unkown-request - run
>>> GATT: < 02 17 00 ...
>>> bt_gatt_server:MTU exchange complete, with MTU: 23
>>> GATT: > 03 00 02 ...
>>> PDU: = 03 00 02 ...
>>> GATT: < bf 00
/robustness/unkown-request - init
/robustness/unkown-request - setup
/robustness/unkown-request - setup complete
/robustness/unkown-request - run
GATT: < 02 17 00 ...
bt_gatt_server:MTU exchange complete, with MTU: 23
GATT: > 03 00 02 ...
PDU: = 03 00 02 ...
GATT: < bf 00 ..
GATT: > 01 bf 00 00 06 .....
PDU: = 01 bf 00 00 06 .....
/robustness/unkown-request - test passed
/robustness/unkown-request - teardown
/robustness/unkown-request - teardown complete
/robustness/unkown-request - done
Test Summary
------------
/robustness/unkown-request Passed 0.001 seconds
Total: 1, Passed: 1 (100.0%), Failed: 0,
>>> Actually, the /robustness/unkown-request test does
>>> no action.
Isn't that last PDU the actual error response, without that the
original intend of the test is lost.
>>> ---
>>> unit/test-gatt.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/unit/test-gatt.c b/unit/test-gatt.c
>>> index c7e28f865..b57373b07 100644
>>> --- a/unit/test-gatt.c
>>> +++ b/unit/test-gatt.c
>>> @@ -4463,7 +4463,7 @@ int main(int argc, char *argv[])
>>> test_server, service_db_1, NULL,
>>> raw_pdu(0x03, 0x00, 0x02),
>>> raw_pdu(0xbf, 0x00),
>>> - raw_pdu(0x01, 0xbf, 0x00, 0x00, 0x06));
>>> + raw_pdu());
>>>
>>> define_test_server("/robustness/unkown-command",
>>> test_server, service_db_1, NULL,
>>>
>
--
Luiz Augusto von Dentz
