Re: [PATCH] Bluetooth: btintel: fix ptr_ret.cocci warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fengguang,

> Coccinelle warns about
> 
>         drivers/bluetooth/btintel.c:416:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Fix it by using PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Fixes: 38ca310b0d2c ("Bluetooth: btintel: Add platform device for rfkill signal")
> CC: Sukumar Ghorai <sukumar.ghorai@xxxxxxxxx>
> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> ---
> 
> 
>  btintel.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -413,10 +413,7 @@ static int btintel_probe(struct platform
> 
>  	reset_gpio_handler = devm_gpiod_get_optional(&pdev->dev,
>  					"reset", GPIOD_OUT_HIGH);
> -	if (IS_ERR(reset_gpio_handler))
> -		return PTR_ERR(reset_gpio_handler);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(reset_gpio_handler);
>  }

this does not apply cleanly to bluetooth-next tree. And then I realized this is against a patch that I have not applied. So sorry for the noise.

Regards

Marcel




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux