Re: [PATCH] Bluetooth: Make BT_HCIUART_RTL configuration option depend on ACPI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 14, 2018 at 11:57 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> At the moment we only support ACPI enumeration for serial port attached
> RTL bluetooth controllers.
>
> This commit adds a dependency on ACPI to the BT_HCIUART_RTL configuration
> option, fixing the following warning when ACPI is not enabled:
>
> drivers/bluetooth/hci_h5.c:920:22: warning: 'rtl_vnd' defined but not used
>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

This fixes the warning,

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

I wonder whether CONFIG_BT_HCIUART_3WIRE should also
depend on ACPI and/or become a silent option, since it's currently
useless when either ACPI or BT_HCIUART_RTL are disabled,
and it seems possible that things break differently when another
back-end gets added there.

     Arnd



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux