Re: [PATCH v3 7/9] Bluetooth: hci_h5: Add vendor setup, open, and close callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jeremy,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on v4.18-rc4 next-20180709]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Hans-de-Goede/Bluetooth-Add-RTL8723BS-support/20180710-165735
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=xtensa 

All errors (new ones prefixed by >>):

   drivers//bluetooth/hci_h5.c: In function 'h5_serdev_probe':
>> drivers//bluetooth/hci_h5.c:810:41: error: dereferencing pointer to incomplete type 'const struct acpi_device_id'
      h5->vnd = (const struct h5_vnd *)match->driver_data;
                                            ^~

vim +810 drivers//bluetooth/hci_h5.c

   788	
   789	static int h5_serdev_probe(struct serdev_device *serdev)
   790	{
   791		const struct acpi_device_id *match;
   792		struct device *dev = &serdev->dev;
   793		struct h5 *h5;
   794	
   795		h5 = devm_kzalloc(dev, sizeof(*h5), GFP_KERNEL);
   796		if (!h5)
   797			return -ENOMEM;
   798	
   799		set_bit(HCI_UART_RESET_ON_INIT, &h5->serdev_hu.flags);
   800	
   801		h5->hu = &h5->serdev_hu;
   802		h5->serdev_hu.serdev = serdev;
   803		serdev_device_set_drvdata(serdev, h5);
   804	
   805		if (has_acpi_companion(dev)) {
   806			match = acpi_match_device(dev->driver->acpi_match_table, dev);
   807			if (!match)
   808				return -ENODEV;
   809	
 > 810			h5->vnd = (const struct h5_vnd *)match->driver_data;
   811			h5->id  = (char *)match->id;
   812		}
   813	
   814		return hci_uart_register_device(&h5->serdev_hu, &h5p);
   815	}
   816	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux