Re: [PATCH v1 03/10] monitor: Add support PHY management commands and event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jaganath,

> ---
> monitor/packet.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
> 
> diff --git a/monitor/packet.c b/monitor/packet.c
> index b800a2d..e3b5ab7 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -97,6 +97,7 @@
> #define COLOR_UNKNOWN_ADDRESS_TYPE	COLOR_WHITE_BG
> #define COLOR_UNKNOWN_DEVICE_FLAG	COLOR_WHITE_BG
> #define COLOR_UNKNOWN_ADV_FLAG		COLOR_WHITE_BG
> +#define COLOR_UNKNOWN_PHY		COLOR_WHITE_BG
> 
> #define COLOR_PHY_PACKET		COLOR_BLUE
> 
> @@ -10611,6 +10612,7 @@ static const struct {
> 	{ 13, "Privacy"			},
> 	{ 14, "Controller Configuration"},
> 	{ 15, "Static Address"		},
> +	{ 16, "PHY Configuration"	},
> 	{ }
> };
> 
> @@ -11905,6 +11907,54 @@ static void mgmt_set_apperance_cmd(const void *data, uint16_t size)
> 	print_appearance(appearance);
> }
> 
> +static const struct {
> +	uint8_t bit;
> +	const char *str;
> +} mgmt_phy_table[] = {
> +	{  0, "1MTX"	},
> +	{  1, "1MRX"	},
> +	{  2, "2MTX"	},
> +	{  3, "2MRX"	},
> +	{  4, "CODEDTX"	},
> +	{  5, "CODEDRX"	},
> +	{ }
> +};

this is unreadable. Use full strings like “LE 1M TX” etc.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux