Hi Rob,
On 2018-06-20 20:24, Rob Herring wrote:
On Wed, Jun 20, 2018 at 5:33 AM, Balakrishna Godavarthi
<bgodavar@xxxxxxxxxxxxxx> wrote:
Hi Rob,
please find my comments inline.
On 2018-06-18 18:59, Rob Herring wrote:
On Sat, Jun 16, 2018 at 12:27 AM, Balakrishna Godavarthi
<bgodavar@xxxxxxxxxxxxxx> wrote:
Signed-off-by: Balakrishna Godavarthi <bgodavar@xxxxxxxxxxxxxx>
[...]
-Example:
+ - vddpa-supply: Bluetooth VDD PA regulator handle
+ - vddio-supply: Bluetooth VDD IO regulator handle
+ - vddldo-supply: Bluetooth VDD LDO regulator handle. Kept under
optional
+ parameters as some of the chipsets doesn't require
ldo
or
+ it may use from same vddio.
You need to be explicit as to which properties apply or don't apply
to
specific compatible strings.
[Bala]: will update.
Supplies should be based on inputs to the chip, so if 1 regulator
supplies 2 inputs you still need both.
[Bala]: sorry i did't get you, all these regulators are single output
line
regulators.
i.e. <supply-name>- supply, need single regulator input as a
handle.
and these line regulators generate fixed voltage output.
please let me know, if i have cleared your query
I was referring to "it may use from same vddio". If you mean vddldo is
left disconnected, then omitting the property is fine. If you mean
vddio and vddldo are connected to the same regulator, then you should
have both properties in the binding.
Rob
may be pharse is confusing, will correct the text.
we require both vregs to turn on wcn3990.
--
Regards
Balakrishna.
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
