Hi Matthias,
>> This patch enables the RAM and NV patch download for wcn3990.
>>
>> Signed-off-by: Balakrishna Godavarthi <bgodavar@xxxxxxxxxxxxxx>
>> ---
>> Changes in v7:
>> * used redefined function qca_uart_setup for firmware download.
>>
>> Changes in v6:
>> * add code to derive the firmware files based on ROM Version.
>> * created new patch for common function of ROME and wcn3990.
>>
>> Changes in v5:
>> * moved changes related to hci_qca.
>> * addressed review comments.
>>
>> Changes in v4:
>> * initial patch.
>> ---
>> drivers/bluetooth/btqca.c | 26 +++++++++++++++++++++-----
>> 1 file changed, 21 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
>> index f748730039cf..f0a4205068b8 100644
>> --- a/drivers/bluetooth/btqca.c
>> +++ b/drivers/bluetooth/btqca.c
>> @@ -332,6 +332,7 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, uint8_t soc_type,
>> {
>> struct rome_config config;
>> int err;
>> + u8 rom_ver;
>>
>> bt_dev_dbg(hdev, "QCA setup on UART");
>>
>> @@ -346,11 +347,21 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, uint8_t soc_type,
>> }
>> bt_dev_info(hdev, "QCA controller version 0x%08x", soc_ver);
>> }
>> -
>> /* Download rampatch file */
>> config.type = TLV_TYPE_PATCH;
>> - snprintf(config.fwname, sizeof(config.fwname), "qca/rampatch_%08x.bin",
>> - soc_ver);
>> + if (soc_type == QCA_WCN3990) {
>> + /* Firmware files to download are based on ROM version.
>> + * ROM version is derived from last two bytes of soc_ver.
>> + */
>
> nit: new line after '/*' (https://www.kernel.org/doc/html/v4.17/process/coding-style.html#commenting))
actually not in the networking code. It has special commenting rules ;)
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
