Re: [PATCH BlueZ 2/2] gatt: Don't require prepare write authorization for trusted devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Grzegorz,

On Tue, May 29, 2018 at 11:32 AM, Grzegorz Kolodziejczyk
<grzegorz.kolodziejczyk@xxxxxxxxxxx> wrote:
> This patch adds possibility to ommit prepare write authorization
> request from trusted devices.
> ---
>  src/gatt-database.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/gatt-database.c b/src/gatt-database.c
> index 22c78e840..99c8ea231 100644
> --- a/src/gatt-database.c
> +++ b/src/gatt-database.c
> @@ -2569,7 +2569,8 @@ static void desc_write_cb(struct gatt_db_attribute *attrib,
>         }
>
>         if (opcode == BT_ATT_OP_PREP_WRITE_REQ) {
> -               if (!desc->prep_authorized && desc->req_prep_authorization)
> +               if (!device_is_trusted(device) && !desc->prep_authorized &&
> +                                               desc->req_prep_authorization)
>                         send_write(device, attrib, desc->proxy,
>                                         desc->pending_writes, id, value, len,
>                                         offset, bt_att_get_link_type(att),
> @@ -2672,7 +2673,8 @@ static void chrc_write_cb(struct gatt_db_attribute *attrib,
>                 queue = NULL;
>
>         if (opcode == BT_ATT_OP_PREP_WRITE_REQ) {
> -               if (!chrc->prep_authorized && chrc->req_prep_authorization)
> +               if (!device_is_trusted(device) && !chrc->prep_authorized &&
> +                                               chrc->req_prep_authorization)
>                         send_write(device, attrib, chrc->proxy, queue,
>                                         id, value, len, offset,
>                                         bt_att_get_link_type(att), true, true);
> --
> 2.13.6

I guess I can ignore the first patch and just apply this one, or do
you still have any use for checking the trusted flag on the client
side?

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux