Re: [PATCH] Fix possible invalid memory access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, May 18, 2018 at 6:58 AM, Nagaraj D R <nagaraj.dr@xxxxxxxxxxx> wrote:
> Uninitialized data is read from local variable 'addr'
> ---
>  client/main.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/client/main.c b/client/main.c
> index 54bd537..73e77c4 100644
> --- a/client/main.c
> +++ b/client/main.c
> @@ -1774,12 +1774,12 @@ static void cmd_disconn(int argc, char *argv[])
>
>         if (argc < 2 || strlen(argv[1]) == 0) {
>                 DBusMessageIter iter;
> -               const char *addr;
>
> -               if (g_dbus_proxy_get_property(proxy, "Address", &iter) == TRUE)
> +               if (g_dbus_proxy_get_property(proxy, "Address", &iter) == TRUE) {
> +                       const char *addr;
>                         dbus_message_iter_get_basic(&iter, &addr);
> -
> -               bt_shell_printf("Attempting to disconnect from %s\n", addr);
> +                       bt_shell_printf("Attempting to disconnect from %s\n", addr);
> +               }
>         } else
>                 bt_shell_printf("Attempting to disconnect from %s\n", argv[1]);
>  }
> --
> 1.9.1

Applied, notice that I did some changes so all commands using
find_device shall use proxy_address when printing the address.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux