Re: [PATCH BlueZ 3/5] doc/gatt-api: Add authorization options for attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,
śr., 16 maj 2018 o 09:16 Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx>
napisał(a):

> Hi Grzegorz,
> On Wed, May 9, 2018 at 2:08 PM Grzegorz Kolodziejczyk <
> grzegorz.kolodziejczyk@xxxxxxxxxxx> wrote:

> > This patch adds authorization property for attributes and prepare write
> > request for authorization option for write request. This is require to
> > handle correctly prepare writes, which may response with insufficient
> > authorization error.
> > ---
> >   doc/gatt-api.txt | 9 +++++++++
> >   1 file changed, 9 insertions(+)

> > diff --git a/doc/gatt-api.txt b/doc/gatt-api.txt
> > index 0f1cc9029..7d2517ccc 100644
> > --- a/doc/gatt-api.txt
> > +++ b/doc/gatt-api.txt
> > @@ -85,6 +85,8 @@ Methods               array{byte} ReadValue(dict
> options)
> >                          Possible options: "offset": Start offset
> >                                            "device": Device path (Server
> only)
> >                                            "link": Link type (Server
only)
> > +                                         "prep-authz-req": boolean Is
> prepare write
> > +
authorization
> request

> I'd keep it simple and just call it authorize.
Ok.

> >                          Possible Errors: org.bluez.Error.Failed
> >                                           org.bluez.Error.InProgress
> > @@ -251,6 +253,11 @@ Properties string UUID [read-only]
> >                                  "secure-read" (Server only)
> >                                  "secure-write" (Server only)

> > +               boolean Authorize [read-only, optional] (Server only)
> > +
> > +                       True, if authorization is required for attribute
> > +                       operations.

> We should probably mention the default is false if the property is not
> available.
Ok.

> >   Characteristic Descriptors hierarchy
> >   ====================================

> > @@ -284,6 +291,8 @@ Methods             array{byte} ReadValue(dict
flags)
> >                          Possible options: "offset": Start offset
> >                                            "device": Device path (Server
> only)
> >                                            "link": Link type (Server
only)
> > +                                         "prep-authz-req": boolean Is
> prepare write
> > +
authorization
> request

> Do we need and authorize flag for read? I thought this was only for
prepare
> write.
I guess this is a confusing patch presentatnion formating :) this option is
for WriteValue not for ReadValue in real, but somehow git format patch
treat "ReadValue" as Method... or something in this way.

> >                          Possible Errors: org.bluez.Error.Failed
> >                                           org.bluez.Error.InProgress
> > --
> > 2.13.6

> > --
> > To unsubscribe from this list: send the line "unsubscribe
> linux-bluetooth" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html



> --
> Luiz Augusto von Dentz

Regards,
Grzegorz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux