Hi Marcel,
On Tue, May 8, 2018 at 2:17 PM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Luiz,
> >>> This adds Flags which the application can use in case it want to set
> >>> it own flags.
> >>>
> >>> Note: This would allow for example an application to advertise as
> >>> discoverable even if the adapter is not discoverable which may be
> >>> required by dual-mode as it may not require BR/EDR to be discoverable.
> >>> ---
> >>> doc/advertising-api.txt | 15 +++++++++++++++
> >>> 1 file changed, 15 insertions(+)
> >>>
> >>> diff --git a/doc/advertising-api.txt b/doc/advertising-api.txt
> >>> index eef98ad91..4e015f282 100644
> >>> --- a/doc/advertising-api.txt
> >>> +++ b/doc/advertising-api.txt
> >>> @@ -78,6 +78,21 @@ Properties string Type
> >>> <Transport Discovery> <Organization
> > Flags...>
> >>> 0x26 0x01
> > 0x01...
> >>>
> >>> + array{byte} Flags [Experimental]
> >>> +
> >>> + Advertising Flags to include. When present this
> > will
> >>> + override existing flags such as Discoverable.
> >>> +
> >>> + Note: This property shall not be set when Type
is
> > set
> >>> + to broadcast.
> >>> +
> >>> + Possible value:
> >>> + bit 0 - LE Limited Discoverable Mode
> >>> + bit 1 - LE General Discoverable Mode
> >>> + bit 2 - BR/EDR Not Supported
> >>> + bit 3 - Simultaneous LE and BR/EDR
> > (Controller)
> >>> + bit 4 - Simultaneous LE and BR/EDR
(Host)
> >>> +
> >
> >> I think this is the wrong approach. Exposing this low-level part is
just
> > giving an API to circumvent and violate the Bluetooth spec. You are
> > inviting apps to create bad advertising data. So NAK.
> >
> > Then we should find some alternative, perhaps only allow certain flags
to
> > be set this way or change the property to just Discoverable.
> I would just add a single property Discoverable that maps to General
Discoverable Mode. If you want to get extra credits, then adding
DiscoverableTimeout (like we have in adapter-api.txt) would allow to switch
it back from discoverable to connectable.
Alright, perhaps we could maintain it as Flags and only allow certain flags
to be set by the application since I do intend to use the same interface to
expose device advertisement so we can remove the AdvertisingData and
AdvertisingFlags from the Device interface. Regarding the Timeout we
already have something similar with Duration, or do you think that there
are use cases that we cannot fulfill? For bit 3-4 I guess we never set
those, but BR/EDR Not Supported could be useful for the application to
control the bearer it wants the remote to connect to.
> Regards
> Marcel
--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
