Re: [PATCH BlueZ 1/5] doc/advertising-api: Add Flags property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

On 08/05/18 08:40, Luiz Augusto von Dentz wrote:
> Hi David,
> On Mon, May 7, 2018 at 7:14 PM Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx>
> wrote:
> 
>> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
> 
>> This adds Flags which the application can use in case it want to set
>> it own flags.
> 
>> Note: This would allow for example an application to advertise as
>> discoverable even if the adapter is not discoverable which may be
>> required by dual-mode as it may not require BR/EDR to be discoverable.
>> ---
>>   doc/advertising-api.txt | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
> 
>> diff --git a/doc/advertising-api.txt b/doc/advertising-api.txt
>> index eef98ad91..4e015f282 100644
>> --- a/doc/advertising-api.txt
>> +++ b/doc/advertising-api.txt
>> @@ -78,6 +78,21 @@ Properties   string Type
>>                                  <Transport Discovery> <Organization
> Flags...>
>>                                  0x26                   0x01
> 0x01...
> 
>> +               array{byte} Flags [Experimental]
>> +
>> +                       Advertising Flags to include. When present this
> will
>> +                       override existing flags such as Discoverable.
>> +
>> +                       Note: This property shall not be set when Type is
> set
>> +                       to broadcast.
>> +
>> +                       Possible value:
>> +                               bit 0 - LE Limited Discoverable Mode
>> +                               bit 1 - LE General Discoverable Mode
>> +                               bit 2 - BR/EDR Not Supported
>> +                               bit 3 - Simultaneous LE and BR/EDR
> (Controller)
>> +                               bit 4 - Simultaneous LE and BR/EDR (Host)
>> +
>>                  array{string} Includes
> 
>>                          List of features to be included in the advertising
>> --
>> 2.14.3
> 
> Any feedback this set?

Thanks for making the patches. This certainly looks like it would
achieve what I need. My use of it would be to read the flags, OR bit 1
(general discovery) and write them back again, so as not to affect the
other flags.

I plan to test it by applying your patches to my local version, but I've
not yet had the chance. I'll comment back as soon as I have.

David
-- 
Website: http://www.flypig.co.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux