Re: [PATCH BlueZ v2 0/1] Allow Non-Ephemeral ECC Key Sets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Brian,

On Fri, Apr 27, 2018 at 8:11 PM Brian Gix <brian.gix@xxxxxxxxx> wrote:

> Version 2, to address uninitialized private_key issue, by adding a new
> API. This is separates the two major tasks of generating ECC key sets,
> which are:

> a) Create a Private Key (Only used here when creating Ephemeral set)
> b) Create the matching Public Key from the Private Key.

> In hindsight, we may have wanted to call the original API something like
> ecc_make_keys() or ecc_make_key_set() instead of the singlular
ecc_make_key.
> Making that change now will require more wide-reaching changes, however.
But
> I am willing to do it in a v3 if people think it better.

> Some minor spelling/capitalization issues were also addressed

> Mesh will be the first to use non-Ephemeral keys

> Brian Gix (1):
>    shared/ecc: Allow pre-composed Private Keys

>   src/shared/ecc.c | 42 +++++++++++++++++++++++++++++-------------
>   src/shared/ecc.h | 17 ++++++++++++++---
>   2 files changed, 43 insertions(+), 16 deletions(-)


I went ahead and applied this one since the bigger set depending on it,
note that I did have to fix the following warning by checkpatch:

  Applying: shared/ecc: Allow pre-composed Private Keys
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#50: FILE: src/shared/ecc.c:887:
+    unsigned tries = 0;

> --
> 2.14.3



-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux