Re: [PATCH 1/6] Bluetooth: btbcm: Stop using upper nibble of rev to chose between uart/USB paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

> btbcm_setup_patchram() was using the upper nibble of the revision code to
> determine if we are dealing with an uart or USB connected bcm-bt device,
> but just as btbcm_initialize() has started accepting 1 and 2 as uart
> connected devices, I've now encountered an USB connected device (0a5c:216c)
> which has 0 in the upper nibble. So it seems that the upper nibble is not
> really a reliable indicator of the bus type.
> 
> Instead check hdev->bus which does give us a reliable indication. This
> fixes the patchram code trying to load the patchram by the fallback BCM.hcd
> filename, now it correctly requests BCM43142A0-0a5c-216c.hcd.
> 
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
> drivers/bluetooth/btbcm.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)

all 6 patches have been applied to bluetooth-next tree.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux