Re: [RFC 2/7] doc/device-api: Add AdvertisingData property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

>>> This adds AdvertisingData which exposes data being advertised which is
>>> may be useful for profiles not handled by bluetoothd.
>>> ---
>>> doc/device-api.txt | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>> 
>>> diff --git a/doc/device-api.txt b/doc/device-api.txt
>>> index 1b448eef1..f2f8464bc 100644
>>> --- a/doc/device-api.txt
>>> +++ b/doc/device-api.txt
>>> @@ -251,3 +251,8 @@ Properties        string Address [readonly]
>>>              array{byte} AdvertisingFlags [readonly, experimental]
>>> 
>>>                      The Advertising Data Flags of the remote device.
>>> +
>>> +             dict AdvertisingData [readonly, experimental]
>>> +
>>> +                     The Advertising Data of the remote device. Keys are
>>> +                     are 8 bits AD Type followed by data as byte array.
>> 
>> this somehow needs to be explained on how a dict like that would look like. And also which AD types are _not_ valid here. Or at least not valid in conjunction with using other properties.
> 
> Sure, I can add a couple of examples for the existing profiles like
> Transport Discovery Data. For the peripheral we could limit the
> available type to just AD types available in the assigned number, like
> a whitelist, or blacklist the types that either kernel or bluetooothd
> are managing, I guess either way would work but maintaining the first
> option might be more troublesome since there are new profile being
> adopted all the time which was the reason why I haven't bother adding
> profile specific properties since we would end up with too many. There
> is also the option to use Advertising1 interface instead of Device1
> that way central and peripheral APIs would be symmetric.

actually I am fine with allowing any AD type, but not allowing conflicting AD type here with other properties. So if you want all freeform, then do it and only use AdvertisingData, but if you want a combination, then certain AD types are not allowed.

Now I just saw that this is Device API, so all AD fields that are not covered by the exposed properties are fair game. My comment about not conflicting data is for the Advertising API.

> Btw, I don't know what went wrong with Service Data type, afaik that
> was meant for the profile to use instead of each creating its own AD
> type, now types can be profile specific without the use of the UUIDs
> which makes it hard to correlate with the actual profile.

Most likely size or some how stupid things that it is not a real service. This reminds me, I would actually also blacklist the Mesh AD Types since they should not be processed via D-Bus. So lets just say which ones are blacklisted.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux