Re: [PATCH BlueZ 1/3] shared/gatt-client: Omit valid errors for primary discovery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Mar 14, 2018 at 3:17 PM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>
> BT_ATT_ERROR_ATTRIBUTE_NOT_FOUND shall not cause anything to be printed
> since it is a valid response and just mark the end of primary discovery.
> ---
>  src/shared/gatt-client.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/shared/gatt-client.c b/src/shared/gatt-client.c
> index 1285c37ef..d61668df7 100644
> --- a/src/shared/gatt-client.c
> +++ b/src/shared/gatt-client.c
> @@ -1023,9 +1023,6 @@ static void discover_primary_cb(bool success, uint8_t att_ecode,
>         discovery_req_clear(client);
>
>         if (!success) {
> -               util_debug(client->debug_callback, client->debug_data,
> -                                       "Primary service discovery failed."
> -                                       " ATT ECODE: 0x%02x", att_ecode);
>                 /* Reset error in case of not found */
>                 switch (att_ecode) {
>                 case BT_ATT_ERROR_ATTRIBUTE_NOT_FOUND:
> @@ -1033,6 +1030,9 @@ static void discover_primary_cb(bool success, uint8_t att_ecode,
>                         att_ecode = 0;
>                         goto secondary;
>                 default:
> +                       util_debug(client->debug_callback, client->debug_data,
> +                                       "Primary service discovery failed."
> +                                       " ATT ECODE: 0x%02x", att_ecode);
>                         goto done;
>                 }
>         }
> --
> 2.14.3

Applied.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux