Re: [PATCH BlueZ 0/9] Commonalize functions appending to dbus message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Eramoto,

On Wed, Feb 28, 2018 at 9:33 AM, ERAMOTO Masaya
<eramoto.masaya@xxxxxxxxxxxxxx> wrote:
> To improve maintainability, this patch set introduces common functions
> for appending to dbus message.
>
> ERAMOTO Masaya (9):
>   gdbus: Introduce functions appending to dbus message
>   obexd: Use g_dbus_dict_append_entry()
>   obexd: Remove unused source/header files for dbus
>   client: Use g_dbus_dict_append_*()
>   mesh: Use g_dbus_dict_append_{entry,array}()
>   tools/obexctl: Use g_dbus_dict_append_entry()
>   tools/bluetooth-player: Use g_dbus_dict_append_entry()
>   unit/test-gdbus-client: Use g_dbus_dict_append_entry()
>   dbus-common: Remove unused functions due to use of g_dbus_dict_append_*()
>
>  Makefile.obexd            |   1 -
>  client/advertising.c      |  58 ++------------------
>  client/main.c             | 100 +++-------------------------------
>  gdbus/client.c            | 135 +++++++++++++++++++++++++++++++++-------------
>  gdbus/gdbus.h             |   9 ++++
>  mesh/main.c               | 100 +++-------------------------------
>  obexd/client/dbus.c       |  94 --------------------------------
>  obexd/client/dbus.h       |  48 -----------------
>  obexd/client/ftp.c        |   7 ++-
>  obexd/client/map.c        |   6 +--
>  obexd/client/session.c    |   1 -
>  obexd/client/transfer.c   |   1 -
>  obexd/plugins/bluetooth.c |  40 ++------------
>  src/dbus-common.c         |  85 +----------------------------
>  src/dbus-common.h         |   6 ---
>  src/device.c              |   3 +-
>  tools/bluetooth-player.c  |  38 ++-----------
>  tools/obexctl.c           |  36 +------------
>  unit/test-gdbus-client.c  |  38 ++-----------
>  19 files changed, 146 insertions(+), 660 deletions(-)
>  delete mode 100644 obexd/client/dbus.c
>  delete mode 100644 obexd/client/dbus.h
>
> --
> 2.14.1

You will probably need to rebase since Ive pushed my changes to some
of the command line tools you have changes against, but otherwise this
set looks very good, so lets try to get the conflicts fixed.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux