Hi, On Fri, Feb 16, 2018, Marcel Holtmann wrote: > > --- a/net/bluetooth/smp.c > > +++ b/net/bluetooth/smp.c > > @@ -893,7 +893,8 @@ static int tk_request(struct l2cap_conn *conn, u8 remote_oob, u8 auth, > > > > /* Don't bother user space with no IO capabilities */ > > if (smp->method == JUST_CFM && > > - hcon->io_capability == HCI_IO_NO_INPUT_OUTPUT) > > + (hcon->io_capability == HCI_IO_NO_INPUT_OUTPUT || > > + hcon->io_capability == HCI_IO_DISPLAY_ONLY)) > > smp->method = JUST_WORKS; > > I leave this up to Johan to decide if this is our desired behavior or > not, but if we go ahead with that, then the comment above also needs > changing. And it also needs to be a more elaborate comment explaining > the reasoning. The change looks ok to me, however I agree that the code comment needs updating. Grzegorz, please fix that and send a v2. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
