Re: [PATCH 2/4 v4] doc/mgmt-api: Add support for Set Phy Configuration command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Feb 21, 2018 at 1:17 PM, Szymon Janc <szymon.janc@xxxxxxxxxxx> wrote:
> Hi,
>
> On Wednesday, 21 February 2018 07:09:49 CET Jaganath K wrote:
>> >>>>>>> I think there is a limitation with current API proposal, user cannot
>> >>>>>>> do extended scanning in only 1M (to scan secondary channel in 1M)
>> >>>>>>> since with 1M we will switch to legacy scanning.
>> >>>>>>
>> >>>>>> Why do we have to switch to legacy scanning for 1M? It seems it would
>> >>>>>> be possible to use extended scanning whenever it is supported
>> >>>>>> regardless of the PHY, or perhaps the spec imposes limitations to
>> >>>>>> certain PHYs? Coded perhaps?
>> >>>>>
>> >>>>> The idea is to enable application to use legacy scanning even if
>> >>>>> controller supports
>> >>>>> extended. (ie if application dont want extended features to be used)
>> >>>>> and unlike advertising
>> >>>>> legacy scanning can not be emulated using extended scanning.
>> >>>>
>> >>>> Bluetooth controller which is doing extended scanning will report
>> >>>> legacy
>> >>>> advertisings as well. It will just use Extended Advertising Report
>> >>>> Event for this purpose and Linux Kernel should handle it.
>> >>>
>> >>> Yes, but the idea here is more on perspective of power savings
>> >>> where in application dont want to scan on secondary channels itself and
>> >>> API should support it.
>> >
>> > Then maybe there should not be dependence between this command and
>> > scan/connect. Actually I do not understand why we have it, need to check
>> > previous conversation.
>> >
>> >> I would agree if this affects passive scanning, but in that case we
>> >> can probably program the scan type when adding a device or only really
>> >> scan on primary channel since the purpose is to connect it doesn't
>> >> really matter what is on the secondary channels, for active scanning I
>> >> don't think we would be saving that much power since that should be
>> >> short-lived so Im not sure we should bother with it.
>> >
>> > In extended advertising there is no such thing as connectable and
>> > scannable at the same time
>> > When device is connectable, then address and optionally advertising
>> > data is in the aux ptr (secondary channel)
>> >
>> > Please also remember that it is up to controller to connect / scan on
>> > secondary PHY based on primary PHY provided by host.
>> > Meaning, host controls primary channel only, which can be 1M or Coded.
>> > Rest is up to controller and data in AUX_PTR of ADV_EXT_IND
>>
>> I would wait for Marcel's comments here.
>
> FWIW Apache Mynewt (master, soon to be released 1.4) has full support for
> Extended Advertising and Scanning including all PHYs (on nRF52840) and data
> fragmentation. You can build blehci app and use it with BlueZ for testing.
>

It looks like we have to use Extended scanning always if supported
(even though i could
not find this restriction in core spec), the test is there in HCI TS spec -
HCI/GEV/BV-03-C [Disallow Mixing Legacy and Extended Scanning
Commands].

Actually in my first patch sets, it was done like this (use extended
features always if supported),
So i will rebase it and resent it for review.

Thanks,
Jaganath
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux