Re: [PATCH BlueZ] unit/test-ecc: Fix uninitialised values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Feb 9, 2018 at 12:41 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Luiz,
>
>> Conditional jump or move depends on uninitialised value(s)
>>  at 0x40208C: test_sample (test-ecc.c:106)
>>  by 0x4022AB: test_invalid_pub (test-ecc.c:272)
>>  by 0x406DA2: run_callback (tester.c:415)
>>  by 0x4E83576: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3)
>>  by 0x4E86B76: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.5400.3)
>>  by 0x4E86F1F: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3)
>>  by 0x4E87231: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.5400.3)
>>  by 0x408245: tester_run (tester.c:830)
>>  by 0x401CC3: main (test-ecc.c:291)
>>
>> Conditional jump or move depends on uninitialised value(s)
>>  at 0x4020D6: test_sample (test-ecc.c:113)
>>  by 0x4022AB: test_invalid_pub (test-ecc.c:272)
>>  by 0x406DA2: run_callback (tester.c:415)
>>  by 0x4E83576: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3)
>>  by 0x4E86B76: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.5400.3)
>>  by 0x4E86F1F: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3)
>>  by 0x4E87231: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.5400.3)
>>  by 0x408245: tester_run (tester.c:830)
>>  by 0x401CC3: main (test-ecc.c:291)
>> ---
>> unit/test-ecc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/unit/test-ecc.c b/unit/test-ecc.c
>> index 98400a253..e0f9723fc 100644
>> --- a/unit/test-ecc.c
>> +++ b/unit/test-ecc.c
>> @@ -91,7 +91,7 @@ static int test_sample(uint8_t priv_a[32], uint8_t priv_b[32],
>>                               uint8_t pub_a[64], uint8_t pub_b[64],
>>                               uint8_t dhkey[32])
>> {
>> -     uint8_t dhkey_a[32], dhkey_b[32];
>> +     uint8_t dhkey_a[32] = {}, dhkey_b[32] = {};
>>       int fails = 0;
>
> does an explicit memset also fixes this?

Applied after changing it to use memsets.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux