Re: [bug report] missing bounds check reading firmware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dan,

> This looks like it only has a small impact...
> 
> 	drivers/bluetooth/bt3c_cs.c:491 bt3c_load_firmware()
> 	warn: overflowed symbol reused:  'size'
> 
> drivers/bluetooth/bt3c_cs.c
>   467          /* Load */
>   468          while (count) {
>   469                  if (ptr[0] != 'S') {
>   470                          BT_ERR("Bad address in firmware");
>   471                          err = -EFAULT;
>   472                          goto error;
>   473                  }
>   474  
>   475                  memset(b, 0, sizeof(b));
>   476                  memcpy(b, ptr + 2, 2);
>   477                  if (kstrtoul(b, 16, &size) < 0)
>                                             ^^^^
> Smatch marks this as untrusted

can you send us a patch fixing these issues?

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux