Re: [PATCH v3 00/13] Bluetooth on 2015+ MacBook (Pro)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lukas,

>> Enable UART-attached Bluetooth on 2015+ Macs, v3.
>> 
>> The series has grown to 13 patches because bugs in the driver keep
>> cropping up.
>> 
>> Changes since v2:
>> 
>> - In patch [01/13] ("Mandate presence of shutdown and device wake
>> GPIO"):
>>  Keep netdev indentation style. (Marcel)
>> 
>> - New patch [04/13] to fix an IRQ race on ->close.
>> 
>> - New patch [05/13] to fix an unbalanced pm_runtime_disable(). (Andy)
>> 
>> - New patch [06/13] to invalidate the IRQ if requesting it failed.
>> 
>> - New patch [08/13] to add callbacks to toggle GPIOs.
>>  This makes the subsequent addition of Mac support less intrusive.
>>  Replaces patch "Add helper to toggle device wake GPIO" in v2. (Andy)
>> 
>> - In patch [09/13] ("Handle errors properly"):
>>  Drop redundant assignment. (Andy)
>> 
>> - In patch [10/13] ("Support Apple GPIO handling"):
>>  Don't enable runtime PM on Macs for lack of usable host wake IRQ
>> (Hans),
>>  s/BlueTooth/Bluetooth/ in kerneldoc. (Marcel)
>> 
>> - Move patch "Silence IRQ printk" to end of series as it's merely
>>  a cleanup and no longer necessary for Mac support.
>> 
>> - New patch [12/13] to use msleep() instead of mdelay()
>>  after toggling device wake pin. (Andy)
>> 
>> - New patch [13/13] to fix sleep mode struct ordering.
>> 
>> - Drop incorrect patch "Enable runtime PM despite absence of IRQ".
>> (Hans)
>> 
> 
> I didn't test this myself (yet), the code looks more or less fine to me,
> FWIW, 
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

can we get a v4 with the known fixes?

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux