Hey,
I've noticed that when using the Pair() method on a device already
paired, it hangs indefinitely (never returns a reply), or potentially
returns an AuthenticationCancelled error, when the device disappears.
The comments in the pair_device(...) function say something about an
SMP bug, and the comments in adapter_bonding_attempt(...) also mention
a bug about some LE pairing requests never timing out.
I'm not really sure if the behavior I mentioned has something to do
with the bug/bugs from the comments or not, so I'm wondering if
there's a reason for not checking if the device is paired already or
not, before proceeding with the pairing?
The following patch stops the indefinite hang for me on second pairing
attempts, and still achieves the side effects of pairing, e.g.
connecting. I'm not 100% sure however that this isn't causing
different problems.
--- a/src/device.c
+++ b/src/device.c
@@ -2490,6 +2490,11 @@ static DBusMessage *pair_device(DBusConnection
*conn, DBusMessage *msg,
if (state->bonded)
return btd_error_already_exists(msg);
+ if (state->paired) {
+ device->bredr_state.paired = false;
+ device->le_state.paired = false;
+ }
+
sender = dbus_message_get_sender(msg);
agent = agent_get(sender);
Cheers,
Ahmed Alsharif.
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
