Hi Inga, On Fri, 2017-12-15 at 02:14 +0000, Stotland, Inga wrote: > Hi Steve, > > On Thu, 2017-12-14 at 02:12 -0700, Steve Brown wrote: > > Hi Inga, > > On Thu, 2017-12-14 at 08:08 +0000, Stotland, Inga wrote: > > > Hi Steve, > > > > > > On Tue, 2017-12-12 at 12:58 +0000, sbrown@xxxxxxxxxxxx wrote: > > > > From: Steve Brown <sbrown@xxxxxxxxxxxx> > > > > > > > > Fix lines over 80 chars > > > > Move cmd_default() > > > > Add parameter to pub-set to control retransmit count > > > > --- > > > > > > > > > > Since you are modifying pub-set command, could you please fix it > > > to > > > correctly indicate SIG and vendor models, similarly to "bind" > > > command > > > (adding an optional "cid" parameter for vendor models). > > > > > > Regards, > > > > > > Inga Stotland > > > > It looks like the pub command already assumes it's a vendor model > > if > > the model id is > 0xffff. Is that a correct assumption? > > > > If it is, should I make the same change to bind and remove the > > optional > > parameter? > > > > Steve > > > The check for model id is > 0xffff is not entirely correct since it > does not account for a case when CID is 0x0000. > > Regards, > > Inga I made the changes/corrections you requested and sent V3. Steve -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
