Hi Luiz, On Mon, 2017-12-11 at 13:49 -0200, Luiz Augusto von Dentz wrote: > Hi Steve, > > On Mon, Dec 11, 2017 at 1:40 PM, Steve Brown <sbrown@xxxxxxxxxxxx> > wrote: > > Hi Luiz, > > > > On Mon, 2017-12-11 at 13:12 -0200, Luiz Augusto von Dentz wrote: > > > Hi Steve, > > > > > > On Mon, Dec 11, 2017 at 12:58 PM, <sbrown@xxxxxxxxxxxx> wrote: > > > > From: Steve Brown <sbrown@xxxxxxxxxxxx> > > > > > > > > Get/Set Proxy > > > > Get/Set Ident > > > > Get/Set Relay > > > > Set Heartbeat > > > > Get Publication > > > > Get/Set Subscription > > > > > > Ive split these into individual patches for command and then add > > > in > > > the description what the expected output, etc. Btw I think it > > > would > > > be > > > better to switch from get-set style to cmd [value], so if there > > > is no > > > arguments then it just read the value, that way reduce the amount > > > of > > > commands and also make the autocomplete a lot more useful since > > > the > > > commands shall start with something other than set/get. > > > > > > > OK, I'll make the changes. > > > > This would then affect all the meshctl commands. > > > > I'll have to rearrange the parameter sequence in some of the > > commands > > so I can distinguish between a get and a set. > > > > So, where the publish commands currently are > > set-pub <ele-addr> <pub-addr> <app-idx> .... and > > get-pub <ele-addr> <model> > > > > They would become > > pub <ele-addr> <model> <pub-addr> .... for set and > > pub <ele-addr> <model> for get > > > > Do I understand this correctly? > > Yep, but note that due to shell parsing the .arg string you may need > to add some parameters to set as optional otherwise the command for > get will never succeed since it will require all mandatory arguments > to be given as in the set version. If that becomes impractical and > cause a lot more code to detect what mode the command shall operate > then perhaps leave as it is and just revert to pub-set/pub-get to > make > autocomplete a little more useful. > > > I left the subscription node and database patch separate. I'm on > > less > > solid ground here. I basically cribbed the code for bind. > > > > I added the UUID to the database as later I'd like to try to re- > > provision a known unprovisioned node from the database. > > > > Steve > > I'm not sure I understand the problem. Some of the get commands require parameters. The same parameters are also required in the set commands, only more. Currently, they aren't in the same order. I was going to rearrange the parameters so the set and get commands have the same parameter sequence. The set command would just have more. That way I can distinguish between them by the number of parameters. Steve -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
