Hi, On Wed, Dec 06, 2017, ERAMOTO Masaya wrote: > On 12/06/2017 03:33 AM, Luiz Augusto von Dentz wrote: > > This makes obexctl use bt_shell to manage the menus and command > > handling. > > --- > > Makefile.tools | 5 +- > > tools/obexctl.c | 609 ++++++++++++++++---------------------------------------- > > 2 files changed, 175 insertions(+), 439 deletions(-) > > The previous obexctl gives arguments included a command name to the command, but > bt_shell gives arguments excluded a command name. So you should fix argc/argv > related processes in each command. Also bt_shell automatically checks passed > arguments. > You can refer to the attached patch about these things. If you ask me, I think we should keep this consistent with obexctl and e.g. how main() gets called. I.e. argv[0] is the command. An added benefit of this is that two very similar commands (taking the same parameters) can use the same command handler, since they'll be able to distuinguish which command was used. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
