Hi Johan, > Hi Jaganath, > > On Mon, Nov 20, 2017, Jaganath Kanakkassery wrote: >> +Get PHY Information Command >> +========================== >> + >> + Command Code: 0x0043 >> + Controller Index: <controller id> >> + Command Parameters: >> + Return Parameters: Supported_phys (1 Octet) >> + Selected_phys (1 Octet) > > Shouldn't the command have "Default" in its name, to be consistent with > your second patch? I did not add "Default" since the API also returns the Supported PHYs by the controller. Will "Current_default_phys" be more intuitive than "Selected_phys"? > If it's not the default that this is returning, then > shouldn't there be a reference to which connection it applies to > (assuming this is intended to map to the HCI_LE_Set_PHY command)? > > What about the PHY_options HCI parameter, where is that planned to be > specified? > This API is not for any connection (and so not mapped to HCI_LE_Set_PHY command). For that we have L2CAP socket option for which i have already raised a patch "[PATCH] Bluetooth: Define l2cap sock option for LE PHYs" As you mentioned we would need to add support for PHY_options in that. Thanks, Jaganath -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
