Re: [PATCH BlueZ] player: Fix clearing track metadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bastien,

On Wed, Nov 22, 2017 at 3:36 PM, Bastien Nocera <hadess@xxxxxxxxxx> wrote:
> On Wed, 2017-11-22 at 15:34 +0200, Luiz Augusto von Dentz wrote:
>> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>>
>> The value stored in the hashtable is the path not the actual pointer
>> of
>> the item.
>> ---
>>  profiles/audio/player.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/profiles/audio/player.c b/profiles/audio/player.c
>> index e499e6757..d12969bf9 100644
>> --- a/profiles/audio/player.c
>> +++ b/profiles/audio/player.c
>> @@ -1885,6 +1885,7 @@ struct media_item
>> *media_player_set_playlist_item(struct media_player *mp,
>>  {
>>       struct media_folder *folder = mp->playlist;
>>       struct media_item *item;
>> +     char *path;
>
> const char *? So it's clear why you don't free it.

Sure.

>
>>       DBG("%" PRIu64 "", uid);
>>
>> @@ -1903,7 +1904,8 @@ struct media_item
>> *media_player_set_playlist_item(struct media_player *mp,
>>               mp->track = g_hash_table_ref(item->metadata);
>>       }
>>
>> -     if (item == g_hash_table_lookup(mp->track, "Item"))
>> +     path = g_hash_table_lookup(mp->track, "Item");
>> +     if (!g_strcmp0(path, item->path))
>>               return item;
>>
>>       if (mp->process_id == 0) {


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux