Re: [PATCH BlueZ] dbus: Fix for unused parameter in WriteValue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

On Tue, Oct 17, 2017 at 7:30 AM, ERAMOTO Masaya
<eramoto.masaya@xxxxxxxxxxxxxx> wrote:
> Hi Michael,
>
> On 10/16/2017 10:47 PM, Michael Simon wrote:
>> The glib iterator was not moved to the second array,
>> which contains the parameter.
>> ---
>>  src/gatt-client.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/src/gatt-client.c b/src/gatt-client.c
>> index 32b3a87..58f14b8 100644
>> --- a/src/gatt-client.c
>> +++ b/src/gatt-client.c
>> @@ -596,6 +596,8 @@ static DBusMessage
>> *descriptor_write_value(DBusConnection *conn,
>>         if (parse_value_arg(&iter, &value, &value_len))
>>                 return btd_error_invalid_args(msg);
>>
>> +        dbus_message_iter_next (&iter);
>> +
>>         if (parse_options(&iter, &offset))
>>                 return btd_error_invalid_args(msg);
>>
>> @@ -986,6 +988,8 @@ static DBusMessage
>> *characteristic_write_value(DBusConnection *conn,
>>         if (parse_value_arg(&iter, &value, &value_len))
>>                 return btd_error_invalid_args(msg);
>>
>> +        dbus_message_iter_next (&iter);
>> +
>>         if (parse_options(&iter, &offset))
>>                 return btd_error_invalid_args(msg);
>>
>
> This patch can not be applied, and the following messages output:
>
>   Applying: dbus: Fix for unused parameter in WriteValue
>   fatal: corrupt patch at line 10
>   Patch failed at 0001 dbus: Fix for unused parameter in WriteValue
>
> Since this patch perhaps has extra line feeds and uses spaces as indent.

I went ahead pushed the patch after fixing the patch myself, not sure
why the patch got malformed perhaps your mail client is mangling it or
something.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux