On 11/10/17 09:33, Szymon Janc wrote:
Hi Szymon,
thanks for the review.
+ switch(adv->type) {
+ case ANDROID_ADVERTISING_EVENT_TYPE_CONNECTABLE:
+ cp->flags |= MGMT_ADV_FLAG_CONNECTABLE;
+ break;
+
+ defualt:
+ break;
This will not compile :)
Actually it *does* compile, in spite of the typo in "defualt" (the
compiler interprets it as a label)
Good catch though!
I then saw the rule in coding-style.txt about using all values of enums
in switch statements (though it isn't enforced for Android builds)
So I'll do that for V2
All of your other remarks applied
Thanks,
Martin
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
