On 10/8/17 6:57 AM, Marcel Holtmann wrote: > Hi Johan, > >>> The current Kconfig for serdev is not compatible when adding ACPI support as it does not work when built as a module as it requires config SERIAL_DEV_CTRL_TTYPORT to be set. This patch makes serdev compiled into the kernel if selected so that config SERIAL_DEV_CTRL_TTYPORT can be correctly set if requiring ACPI support. <snip> >> I understand why you want this (to prevent hci_bcm from breaking), but we >> should generally not have new entries default to y. >> <snip> >> It may be better to have BT_HCIUART_BCM depend on (or select?) >> SERIAL_DEV_CTRL_TTYPORT instead. > > if we move SERIAL_DEV_BUS to bool, then I would just have it be selected by BT_HCIUART_BCM. Frankly the SERIAL_DEV_BUS option is pretty hard to find in the kernel config. And if we depend on TTY, but then select SERIAL_DEV_BUS, I think that is a good compromise. > > Regards > > Marcel > Hi, Many thanks for everyone's comments on my earlier patch to Kconfigs for ACPI serdev support. I've submitted a revised patch set which addresses the points raised by making BT_HCIUART_BCM dependent on SERIAL_DEV_CTRL_TTYPORT which in turn is dependent on SERIAL_DEV_BUS and ensures that if SERIAL_DEV_BUS is selected is the code is build it. Please can you review and let me know if any further changes are required? Regards, Ian -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
