Hi Fred,
>> As the overwriting of IRQ polarity to active low occurs during the driver
>> probe using 'bt_dev_warn' to display the warning results in '(null)'
>> being displayed for the device. This patch uses the underlying 'BT_INFO'
>> to directly display the warning instead.
>>
>> Signed-off-by: ianwmorrison <ianwmorrison@xxxxxxxxx>
>> ---
>> drivers/bluetooth/hci_bcm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
>> index 77326eeb6146..17c036599407 100644
>> --- a/drivers/bluetooth/hci_bcm.c
>> +++ b/drivers/bluetooth/hci_bcm.c
>> @@ -839,7 +839,7 @@ static int bcm_acpi_probe(struct bcm_device *dev)
>> dmi_id = dmi_first_match(bcm_active_low_irq_dmi_table);
>> if (dmi_id) {
>> - bt_dev_warn(dev, "%s: Overwriting IRQ polarity to active low",
>> + BT_INFO("%s: Overwriting IRQ polarity to active low",
>> dmi_id->ident);
>> dev->irq_active_low = true;
>> }
>
> We can also set the device name before calling bcm_acpi_probe(), i.e. moving "dev->name = dev_name(dev->dev);" from bcm_get_resources() to bcm_probe() and bcm_serdev_probe().
frankly I have no idea on how this works at all. We are using bt_dev_warn on a bcm_device struct. It is meant to be used on a hci_dev struct. So by pure luck bcm_device->name actually exists.
This should have been a dev_warn(dev->dev, ..) call actually.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
