Hi Eramoto,
On Mon, Sep 25, 2017 at 7:21 AM, ERAMOTO Masaya
<eramoto.masaya@xxxxxxxxxxxxxx> wrote:
> This patch set fixes bugs of advertising.c and refactors
> advertise-related code.
>
> Changes since v1:
> - Merge 5th and 6th patches into a new patch
>
> ERAMOTO Masaya (5):
> client: Fix memory leak of advertise command
> client: Fix core dump when using set-advertise-name
> client: Prevent to pass invalid ad type to D-Bus
> client: Use existing function for parsing argument
> client: Use new parse_argument() instead of parse_argument_XX()
>
> client/advertising.c | 14 +++++--
> client/main.c | 107 ++++++++++++---------------------------------------
> 2 files changed, 35 insertions(+), 86 deletions(-)
>
> --
> 2.7.4
Applied, thanks.
Note that Ive changed it a little bit since I did push a patch
removing the const char * const construct. Also this consolidation of
parsing might actually be better put into an argument struct to be
part of the command table e.g.:
struct bt_shell_arg {
const char **options;
bool required;
};
The options array can be used for both parsing and auto complete that
way we can have a function that parses them before the actual callback
of cmd_table, though I think this should go directly to bt_shell so
every tool would have the same logic.
--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
