Re: [PATCH 2/2] hostname: Fix "BlueZ 5.XX" adapter name on startup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bastien,

> The hostname plugin listens to property changes from systemd-hostnamed
> but doesn't fetch initial values. This means that unless the
> PrettyHostname or StaticHostname changes, the default adapter will be
> called "BlueZ 5.XX" matching the version number.
> 
> This is the case since the hostname plugin replaced the adaptername
> plugin in 2012.
> 
> Fetch the initial values for PrettyHostname, StaticHostname and
> Chassis when the plugin is initiated, so as to make the values
> available for adapter setup.
> ---
> plugins/hostname.c | 4 ++++
> 1 file changed, 4 insertions(+)
> 
> diff --git a/plugins/hostname.c b/plugins/hostname.c
> index f876d0afb..db9187378 100644
> --- a/plugins/hostname.c
> +++ b/plugins/hostname.c
> @@ -307,6 +307,10 @@ static int hostname_init(void)
> 		hostname_proxy = NULL;
> 		g_dbus_client_unref(hostname_client);
> 		hostname_client = NULL;
> +	} else {
> +		g_dbus_proxy_refresh_property(hostname_proxy, "PrettyHostname");
> +		g_dbus_proxy_refresh_property(hostname_proxy, "StaticHostname");
> +		g_dbus_proxy_refresh_property(hostname_proxy, "Chassis");
> 	}

I am 100% certain that I tested this since this would be a really dumb plugin otherwise. However is it possible that when calling GetManagedObjects the values are not returned correctly? Can we check that. Or does the property watch has an issue not calling the callback correctly.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux